Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› [BugFix] EvalLogSearchTitle 의 totalCount κ°€ query 의 error λ‚˜ loading μƒνƒœλ₯Ό λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ • #221

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

jpham005
Copy link
Member

@jpham005 jpham005 commented Aug 4, 2023

Summary

EvalLogSearchTitle 의 totalCount κ°€ query 의 error λ‚˜ loading μƒνƒœλ₯Ό λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ •

μ• μ΄ˆμ— λ°±μ—”λ“œμ—μ„œ 같은 상황에 λ‹€λ₯Έ κ²°κ³Όλ₯Ό λ°˜ν™˜ν•˜μ—¬ μƒκΈ°λŠ” 문제라고 νŒλ‹¨ν•˜μ—¬,
λ°±μ—”λ“œ api 도 ν˜„μž¬λŠ” λ‘˜ λ‹€ 빈 배열을 λ°˜ν™˜ν•˜λ„λ‘ μˆ˜μ •λœ μƒνƒœ μž…λ‹ˆλ‹€.
단, μ–΄λ–€ μ΄μœ λ‘œλ“  μ—λŸ¬λŠ” λ°œμƒν•  κ°€λŠ₯성이 있기 λ•Œλ¬Έμ—, 이λ₯Ό λ°˜μ˜ν•˜λŠ” λ‘œμ§λ„ μΆ”κ°€ν•˜λŠ” 것이 μ˜³λ‹€κ³  νŒλ‹¨ν–ˆμŠ΅λ‹ˆλ‹€.

Describe your changes

EvalLogSerach/index.tsx 에 caclulateTotalCount ν•¨μˆ˜ μΆ”κ°€,
ν•΄λ‹Ή ν•¨μˆ˜λŠ” query 의 κ²°κ³Όλ₯Ό λ°›μ•„μ„œ number | undefined λ₯Ό λ°˜ν™˜ν•˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€.

Issue number and link

@jpham005 jpham005 added the bug Something isn't working label Aug 4, 2023
@jpham005 jpham005 requested a review from yoopark August 4, 2023 11:13
@jpham005 jpham005 self-assigned this Aug 4, 2023
Copy link
Contributor

@yoopark yoopark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—λŸ¬ λ°œμƒ μ‹œ 0을 λ°˜ν™˜ν•˜λŠ”κ΅°μš” γ…Žγ…Ž κ°μ‚¬ν•©λ‹ˆλ‹€

@jpham005 jpham005 force-pushed the fix/eval-log-error-handle branch from 4ca9ba2 to 4fa1e56 Compare August 5, 2023 11:20
β€¦λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ •

μ• μ΄ˆμ— λ°±μ—”λ“œμ—μ„œ 같은 상황에 λ‹€λ₯Έ κ²°κ³Όλ₯Ό λ°˜ν™˜ν•˜μ—¬ μƒκΈ°λŠ” 문제라고 νŒλ‹¨ν•˜μ—¬,
λ°±μ—”λ“œ api 도 ν˜„μž¬λŠ” λ‘˜ λ‹€ 빈 배열을 λ°˜ν™˜ν•˜λ„λ‘ μˆ˜μ •λœ μƒνƒœ μž…λ‹ˆλ‹€.
단, μ–΄λ–€ μ΄μœ λ‘œλ“  μ—λŸ¬λŠ” λ°œμƒν•  κ°€λŠ₯성이 있기 λ•Œλ¬Έμ—, 이λ₯Ό λ°˜μ˜ν•˜λŠ” λ‘œμ§λ„ μΆ”κ°€ν•˜λŠ” 것이 μ˜³λ‹€κ³  νŒλ‹¨ν–ˆμŠ΅λ‹ˆλ‹€.

- close #201
@jpham005 jpham005 force-pushed the fix/eval-log-error-handle branch from 4fa1e56 to 910d129 Compare August 5, 2023 11:20
@jpham005 jpham005 marked this pull request as ready for review August 5, 2023 11:21
@jpham005 jpham005 merged commit 90fe48b into main Aug 5, 2023
@jpham005 jpham005 deleted the fix/eval-log-error-handle branch August 5, 2023 11:21
@42sungwook 42sungwook changed the title πŸ› fix: EvalLogSearchTitle 의 totalCount κ°€ query 의 error λ‚˜ loading μƒνƒœλ₯Ό λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ • πŸ› [BugFix] EvalLogSearchTitle 의 totalCount κ°€ query 의 error λ‚˜ loading μƒνƒœλ₯Ό λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ • Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: βœ… Done
2 participants