Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [Design] 대시보드 카드 description 정렬 등 #215

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Aug 1, 2023

Summary

Describe your changes

dataLabel xoffset을 줄이는 방식으로 해결

image

DashboardContent에서 title은 있으나 description이 없는 경우에는 공백( )를 추가하여 정렬을 맞춤.
(selection 하면 공백이 드래그되는게 조금 불편하긴 한데, 1.8rem보다 직관적인 것 같아 그렇게 작성하였습니다.)

image

해결 방법은 못 찾았지만, #206을 해결하면서 DashboardContent 높이가 낮아지면서 문제가 어느정도 나아졌습니다.

image

DashboardContent에 type으로 'Default' | 'ApexCharts' | 'Scrollable'을 받게 하여 title, description 정보의 원천을 하나로 통일했습니다.

image
  • 추가로, 예전에 legend hover, click 시 효과를 없앴었는데, 굳이 없앨 필요가 없어서 되살렸습니다.
image

Issue number and link

@yoopark yoopark added the enhancement New feature or request label Aug 1, 2023
@yoopark yoopark merged commit d550e48 into main Aug 1, 2023
@yoopark yoopark deleted the design/dashboard-card-alignment branch August 1, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment