Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ’„ [Design] ์ฐจํŠธ ๊ฐ€๋…์„ฑ ์ œ๊ณ  #194

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

yoopark
Copy link
Contributor

@yoopark yoopark commented Aug 1, 2023

Summary

์ฐจํŠธ ๊ฐ€๋…์„ฑ์„ ๋†’์˜€์Šต๋‹ˆ๋‹ค.

Describe your changes

๊ธฐ์กด์ด ์™ผ์ชฝ, ์ˆ˜์ •์ด ์˜ค๋ฅธ์ชฝ์ž…๋‹ˆ๋‹ค.

์—ฌํ–‰ ์ค‘์ธ ์œ ์ € ๋ ˆ๋ฒจ ๋ถ„ํฌ

image image

์„œํด ๋ณ„ ํ‰๊ท  ํ†ต๊ณผ ๊ธฐ๊ฐ„

image image

๋ธ”๋ž™ํ™€ ์œ ์ € ๋น„์œจ

  • ์ฐจํŠธ ์ „์ฒด์— ์ ์šฉ๋˜๋Š” ํฐํŠธ๋ฅผ Pretendard๋กœ ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค. PieChart์—์„œ ๋ณ€ํ™”๊ฐ€ ๊ฐ€์žฅ ๋‘๋“œ๋Ÿฌ์ง‘๋‹ˆ๋‹ค.
image image

์ง์ „ ํšŒ์ฐจ ์‹œํ—˜ ํ†ต๊ณผ์œจ

image image

์—ฌํ–‰ ์ค‘์ธ ์œ ์ € ์ˆ˜ ์ถ”์ด

  • ์ด ์นด๋“œ์™€ ๊ฐ™์ด datetime ๋ฅ˜ ์ฐจํŠธ์— ๋Œ€ํ•˜์—ฌ, xlabel ์‹ฑํฌ๊ฐ€ ๋„์ €ํžˆ ์•ˆ ๋งž์•„์„œ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ํ˜ธ๋ฒ„ ์‹œ ์•„๋ž˜ ๋ผ๋ฒจ ๋น„์Šทํ•˜๊ฒŒ ์—ญํ• ์„ ํ•ด์ฃผ๋‹ˆ๊นŒ ์ด์ƒํ•˜์ง„ ์•Š๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค.
image image

์—ญ๋Œ€ ์ฝ”์•Œ๋ฆฌ์ˆ‘ ์Šค์ฝ”์–ด ๋ณ€๋™ ์ถ”์ด

  • LineChart์˜ ์„ ์„ ๊ตต๊ฒŒํ•˜๊ณ , smooth๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๊ฐ€๋…์„ฑ์„ ๋†’์˜€์Šต๋‹ˆ๋‹ค.
  • ์œ„ ์นด๋“œ์™€ ๋™์ผํ•˜๊ฒŒ datetime ๋ฅ˜ ์ฐจํŠธ์ด๋ฏ€๋กœ xlabel์„ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋ฐ์ดํ„ฐ ์ „์ฒด์˜ ์ตœ์†Œ/์ตœ๋Œ€๊ฐ’์„ ๊ณ„์‚ฐํ•˜์—ฌ min, max range๋ฅผ ์กฐ์ •ํ•˜๊ธฐ ๋•Œ๋ฌธ์— ๊ฐ’ ๋ณ€ํ™”์— ์œ ๋™์ ์œผ๋กœ ๋Œ€์‘ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
image image

๋ˆ„์  ์ฝ”์•Œ๋ฆฌ์ˆ‘ ์Šค์ฝ”์–ด ํ•ฉ์‚ฐ

  • ๐Ÿ’„ [Design] yeju ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜ย #188 ์—์„œ ์ œ๊ธฐ๋˜์—ˆ๋˜ ์ด์Šˆ๋กœ, ์ตœ์†Œ๊ฐ’์„ 50%๋กœ ์œ„์น˜ํ•˜๋„๋ก min ๊ฐ’์„ ์กฐ์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ์œ„์— ํ‘œ์‹œ๋˜๋Š” dataLabel์ด ์ž˜ ๋‚˜์˜ค๋„๋ก max๋ฅผ ์กฐ์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์œ„ ์นด๋“œ์™€ ๋™์ผํ•˜๊ฒŒ min, max ๊ณ„์‚ฐ ๊ณผ์ •์— ๋ฐ์ดํ„ฐ์˜ ์ตœ์†Œ/์ตœ๋Œ€๊ฐ’์„ ํŒŒ์•…ํ•˜๋Š” ๋กœ์ง์ด ๋“ค์–ด๊ฐ€ ์žˆ์–ด ๊ฐ’ ๋ณ€ํ™”์— ์œ ๋™์ ์œผ๋กœ ๋Œ€์‘ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
image image

๋ ˆ๋ฒจ ์ฆ๊ฐ€ ๊ทธ๋ž˜ํ”„

  • dajeon ๋ ˆ๋ฒจ ์ฆ๊ฐ€ ๊ทธ๋ž˜ํ”„ undefined ๊ฐœ์›”ย #158 ๋ฌธ์ œ๋ฅผ ์šฐํšŒ์ ์œผ๋กœ ํ•ด๊ฒฐํ•˜๋Š” ๋ฐฉ๋ฒ•์„ ์ฐพ์•„์„œ 2๋…„ ์ดํ•˜ ์œ ์ €์˜ ๊ฒฝ์šฐ ๋’ค ์ชฝ์„ ๋น„์šฐ๋Š” ๋ทฐ๋ฅผ ๋‹ค์‹œ ์‚ด๋ ธ์Šต๋‹ˆ๋‹ค.
  • ์˜ค๋ž˜ ํ•œ ์œ ์ €์— ๋Œ€ํ•ด์„œ๋Š” [0...24] ๊ฐœ์›”์ฐจ ์ •๋ณด๊ฐ€ ๋ชจ๋‘ ์ฃผ์–ด์ง€์ง€๋งŒ, ์•„์ง 2๋…„ ์ •๋ณด๊ฐ€ ๋‹ค ์ฃผ์–ด์ง€์ง€ ์•Š์€ ๊ฒฝ์šฐ ๋ฐ์ดํ„ฐ ๋’ค์— { x: 13, y: null }์˜ ํ˜•์‹์œผ๋กœ x: 24๊นŒ์ง€ ์ถ”๊ฐ€ํ•˜๋Š” ๋ฐฉ์‹์œผ๋กœ ์ถ”๊ฐ€ํ•ด์ค๋‹ˆ๋‹ค. ์ดํ›„ ์ฐจํŠธ์—์„œ null ๊ฐ’์ธ ๊ฒฝ์šฐ '๋ฏธ์ •' ๋ฌธ์ž์—ด์„ ํ‘œ์‹œํ•˜๋Š” ๋ฐฉ์‹์œผ๋กœ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
image image
  • Versus์˜ ๊ฒฝ์šฐ์— ๋‹ค์Œ๊ณผ ๊ฐ™์ด ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
image

์ถ”๊ฐ€. ๋ชจ๋ฐ”์ผ ํ™”๋ฉด์—์„œ์˜ ๊ฐ€๋…์„ฑ ์ œ๊ณ 

  • ๊ทผ๋ณธ์ ์ธ ๋ณ€ํ™”๋Š” ์•„๋‹™๋‹ˆ๋‹ค๋งŒ, yLabel ์ •๋ณด๋ฅผ ์ˆจ๊ธฐ๊ฑฐ๋‚˜ tickAmount๋ฅผ ์ค„์ด๋Š” ์‹์œผ๋กœ ๊ฐ€๋…์„ฑ์„ ์กฐ๊ธˆ ๋†’์˜€์Šต๋‹ˆ๋‹ค.
  • ๋ณ€๊ฒฝ๋œ ์นด๋“œ ์ด๋ฏธ์ง€๋ฅผ ์ฒจ๋ถ€ํ•ฉ๋‹ˆ๋‹ค.
  • ์ฝ”์•Œ๋ฆฌ์ˆ‘ ์Šค์ฝ”์–ด ๋ณ€๋™ ์ถ”์ด : 60,000 -> 60K
image image
  • ๋ ˆ๋ฒจ ์ฆ๊ฐ€ ๊ทธ๋ž˜ํ”„ : Tablet ์ด์ƒ์ผ ๋•Œ๋Š” xLabel์ด 3๊ฐœ์›” ๋‹จ์œ„๋กœ, Mobile์ผ ๋•Œ๋Š” 6๊ฐœ์›” ๋‹จ์œ„๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
image image

Issue number and link

@yoopark yoopark added the enhancement New feature or request label Aug 1, 2023
@yoopark yoopark self-assigned this Aug 1, 2023
@yoopark yoopark merged commit 6b14777 into main Aug 1, 2023
@yoopark yoopark deleted the design/chart-readability branch August 1, 2023 06:49
@42sungwook 42sungwook changed the title ๐Ÿ’„[Design] ์ฐจํŠธ ๊ฐ€๋…์„ฑ ์ œ๊ณ  ๐Ÿ’„ [Design] ์ฐจํŠธ ๊ฐ€๋…์„ฑ ์ œ๊ณ  Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: โœ… Done
Development

Successfully merging this pull request may close these issues.

dajeon ๋ ˆ๋ฒจ ์ฆ๊ฐ€ ๊ทธ๋ž˜ํ”„ undefined ๊ฐœ์›”
1 participant