refactor(evallog): trim 시 undefined 전달 -> optional

42Statistics · Oct 12, 2023 · 5273bd2 · 5273bd2
1 parent d3eb822
commit 5273bd2
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/app/src/EvalLogSearch/utils/trimEvalLogSearchForm.ts b/app/src/EvalLogSearch/utils/trimEvalLogSearchForm.ts
@@ -3,12 +3,24 @@ import type { EvalLogSearchForm } from '@/EvalLogSearch/components/EvalLogSearch
 export const trimEvalLogSearchForm = (
   form: EvalLogSearchForm,
 ): EvalLogSearchForm => {
-  const { projectName, corrector, corrected } = form;
-
-  return {
-    ...form,
-    projectName: projectName?.trim() ?? undefined,
-    corrector: corrector?.trim() ?? undefined,
-    corrected: corrected?.trim() ?? undefined,
-  };
+  const { projectName, corrector, corrected, ...rest } = form;
+
+  const newForm: EvalLogSearchForm = { ...rest };
+
+  const trimmedProjectName = projectName?.trim();
+  if (projectName) {
+    newForm.projectName = trimmedProjectName;
+  }
+
+  const trimmedCorrector = corrector?.trim();
+  if (corrector) {
+    newForm.corrector = trimmedCorrector;
+  }
+
+  const trimmedCorrected = corrected?.trim();
+  if (corrected) {
+    newForm.corrected = trimmedCorrected;
+  }
+
+  return newForm;
 };