Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for php 8.4 #211

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Support for php 8.4 #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.3, 8.2, 8.1]
php: [8.4, 8.3, 8.2, 8.1]
laravel: ["^11.0", "^10.0", "^9.0", "^8.12"]
dependency-version: [prefer-lowest, prefer-stable]
include:
Expand Down
6 changes: 3 additions & 3 deletions src/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @param null $guard
* @return bool
*/
function can_impersonate(string $guard = null): bool
function can_impersonate(?string $guard = null): bool
{
$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();

Expand All @@ -28,7 +28,7 @@ function can_impersonate(string $guard = null): bool
* @param string|null $guard
* @return bool
*/
function can_be_impersonated(Authenticatable $user, string $guard = null): bool
function can_be_impersonated(Authenticatable $user, ?string $guard = null): bool
{
$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();
return app('auth')->guard($guard)->check()
Expand All @@ -45,7 +45,7 @@ function can_be_impersonated(Authenticatable $user, string $guard = null): bool
* @param string|null $guard
* @return bool
*/
function is_impersonating(string $guard = null): bool
function is_impersonating(?string $guard = null): bool
{
$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();

Expand Down