Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Feature/positional param ordering #81

Merged
merged 6 commits into from
Nov 25, 2019
Merged

Feature/positional param ordering #81

merged 6 commits into from
Nov 25, 2019

Conversation

rasmusjelsgaard
Copy link
Contributor

@rasmusjelsgaard rasmusjelsgaard commented Nov 21, 2019 •
edited
Loading

  • Quality of life improvement. Lets you omit the param name of the first mandatory parameter, which is often all you need to specify.

Closes #78

@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #81   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         240    240           
=====================================
  Hits          240    240
Impacted Files Coverage Δ
Source/Public/Invoke-DockerPush.ps1 100% <ø> (ø) ⬆️
Source/Public/Format-DockerTag.ps1 100% <ø> (ø) ⬆️
Source/Public/Invoke-DockerLogin.ps1 100% <ø> (ø) ⬆️
Source/Public/Invoke-DockerTests.ps1 100% <ø> (ø) ⬆️
Source/Public/Invoke-DockerTag.ps1 100% <ø> (ø) ⬆️
Source/Public/Invoke-DockerPull.ps1 100% <ø> (ø) ⬆️
Source/Public/Invoke-DockerLint.ps1 100% <ø> (ø) ⬆️

zionyx
zionyx suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@zionyx zionyx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good improvement. But this does not fix #51 however. 😅

@zionyx
Copy link
Contributor

zionyx commented Nov 21, 2019

Until -Registry and -Tag are eliminated. 🤩

@rasmusjelsgaard
Copy link
Contributor Author

This looks like a good improvement. But this does not fix #51 however. 😅

You are right. I linked to the wrong issue. It closes #78

@rasmusjelsgaard rasmusjelsgaard marked this pull request as ready for review November 22, 2019 06:36
zionyx
zionyx approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@zionyx zionyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Rasmus. Standard of living is rising. 🌞

LGTM. Have a look at my comments too.

Source/Public/Format-DockerTag.ps1
param (
[Parameter(ValueFromPipelineByPropertyName = $true)]
[Parameter(ValueFromPipelineByPropertyName = $true, Position = 0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🌞

@rasmusjelsgaard rasmusjelsgaard merged commit 5ef285f into master Nov 25, 2019
@rasmusjelsgaard rasmusjelsgaard deleted the feature/positional_param_ordering branch November 25, 2019 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zionyx zionyx zionyx approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Positional args for all relevant cmdlets
3 participants
@rasmusjelsgaard @zionyx @jetersen