Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error raised when trying to connect to a sentinel addr that cannot be resolved #158

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix error raised when trying to connect to a sentinel addr that cannot be resolved #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/3scale/backend/extensions/redis.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ def sentinel_detect
return result
end
rescue BaseConnectionError
rescue RuntimeError => exception
# Needed because when the sentinel address cannot be resolved it
# raises this instead of "BaseConnectionError"
raise unless exception.message =~ /Name or service not known/
ensure
client.disconnect
end
Expand Down