-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Update prometheus-exporter-operator to manage possible different GrafanaDashboard apiVersions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heusexporter ansile role
… label selector fields depending on grafana_dashboard_api_version value at prometheusexporter ansile role
…hboard.apiVersion
3scale-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
kind/feature
Categorizes issue or PR as related to a new feature.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
labels
Sep 1, 2023
3scale-robot
added
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
size/M
Requires about a day to complete the PR or the issue.
and removed
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
labels
Sep 1, 2023
roivaz
approved these changes
Sep 4, 2023
LGTM label has been added. Git tree hash: 78c8cc12e94b6ff462a09f49afc5f88f8b3c7f4d
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Sep 4, 2023
This was referenced Sep 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/bug
Categorizes issue or PR as related to a bug.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/M
Requires about a day to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #48 it was reported a bug which made the operator to fail on the management of the GrafanaDashboard custom resource, due to using an old API.
It seems there is an API change on grafana-operator v5.0.0 from June 2023 https://github.com/grafana-operator/grafana-operator/releases/tag/v5.0.0
According to the migration docs https://github.com/grafana-operator/grafana-operator/blob/master/docs/blog/v4-v5-migration.md, it affects to prometheus-exporter-operator on 2 places:
integreatly.org/v1alpha1
grafana.integreatly.org/v1beta1
)metadata.labelX
spec.instanceSelector.matchLabels.labelX
So the operator has been adapted to have the 2 possible
GrafanaDashboard
apiVersions
, since there is a breaking change at grafana-operator level, and it is really possible that not everybody have updated yet to newer grafana-operator v5.0.0:grafanaDashboard.apiVersion
CRD field with the 2 possible apiVersionsGrafanaDashboard
with the 2 different apiversion/ labelSelector depending on the value ofgrafanaDashboard.apiVersion
(if defined in the CR), or using the default value (if not defined in the CR)grafanaDashboard.apiVersion
will be the oldapiVersion=v1alpha1
, the one used by most people at the momentspec.grafanaDashboard.apiVersion = v1beta1
apiVersion=v1beta1
spec.grafanaDashboard.apiVersion
/kind bug
/kind feature
/priority important-soon
/assign