Checking that the context that is being rest for a disposable context is indeed a disposable context #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @3lvis I am seeing an odd issue when using a disposable context combined with Sync syncing a background context.
What's happening is I have a disposable context that never has save called on it. It creates a temporary object that is just used to create a request. When that request returns it kicks off Sync which creates a background context.
I have spend a ton of time trying to track it down but for some reason when the background context is saved it causes the newDisposableMainContextWillSave to be triggered even though the observer was never set on the background context. This causes the background context which data I actually want to be stored to be reset and lost.
I also tried to create a unit test to reproduce this with no success. The even stranger part is it doesn't happen every time.
My fix is simple it just checks if the context calling newDisposableMainContextWillSave is really a disposable context. If not don't reset it.