Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 457 #459

Merged
merged 9 commits into from
Jan 30, 2018
Merged

Bug 457 #459

merged 9 commits into from
Jan 30, 2018

Conversation

3lvis
Copy link
Owner

@3lvis 3lvis commented Dec 16, 2017

No description provided.

@3lvis 3lvis changed the title Bug 458 Bug 457 Dec 16, 2017
@3lvis
Copy link
Owner Author

3lvis commented Dec 17, 2017

I can confirm the bug, the relationship should only be removed when sending

category: {}

or

category: null

Tracing back changes to #324

and #320

@batjo
Copy link
Collaborator

batjo commented Jan 29, 2018

Hi @3lvis I found the problem of this issue: if the json couldn't be casted as [String: Any] it would always delete the relationship. I changed it so it checks if the relationship name key exists with a nil value and if it does only then deletes the relationship.

@3lvis 3lvis merged commit 1ac1875 into master Jan 30, 2018
@3lvis 3lvis deleted the bug-458 branch January 30, 2018 23:37
@3lvis
Copy link
Owner Author

3lvis commented Jan 30, 2018

🔥 👏 👏 👏 👏 👏 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants