-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeaturesTable structure & columns improvements #5013
Conversation
40c78d3
to
a23211f
Compare
a23211f
to
ce00f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the component & CSS to fix broken styles (blue background on hover, margins, fonts, etc.). It has been tested for release_3_9
. Style is broken in master, as for other parts of LWC
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5013-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ce00f1aba8ba1b217cda69a0e8aa7cac98203530
# Push it to GitHub
git push --set-upstream origin backport-5013-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_9 release_3_9
# Navigate to the new working tree
cd .worktrees/backport-release_3_9
# Create a new branch
git switch --create backport-5013-to-release_3_9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ce00f1aba8ba1b217cda69a0e8aa7cac98203530
# Push it to GitHub
git push --set-upstream origin backport-5013-to-release_3_9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_9 Then, create a pull request where the |
Added
<div>
by an HTML<table>
to prepare the addition of columns<lizmap-field ... > ... </lizmap-field>
children inside the<lizmap-features-table>
element"libsquart"
and not expressions likerand(10,34)
.Example code:
How it is rendered (in release_3_9, not in master since bootstrap migration is not finished yet)
Fixed
Fix version of #4922
Funded by 3liz