Python examples #365
Merged
Python examples #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #365 +/- ##
========================================
Coverage 71.10% 71.10%
========================================
Files 271 271
Lines 30307 30307
========================================
Hits 21551 21551
Misses 8756 8756 ☔ View full report in Codecov by Sentry. |
gangatp
reviewed
May 15, 2024
SDK/Examples/Python/3mf_convert.py
Outdated
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
| SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| This file has been generated by the Automatic Component Toolkit (ACT) version 1.6.0-develop. |
There was a problem hiding this comment.
Are these files autogenerated?
There was a problem hiding this comment.
@gangatp Sorry. Copy pasted from the existing example.
gangatp
reviewed
May 15, 2024
That's a good point. I will make changes to make it work either way. |
… not installed through PyPI, the examples would work as long as the SDK structure is maintained)
|
@gangatp I have made the changes in the latest commit. I have also removed the line from ACT. |
gangatp
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of python examples as mentioned in #343