Skip to content

Commit

Permalink
TST: Don't assert that a bug exists in numpy (pandas-dev#16940)
Browse files Browse the repository at this point in the history
Better to ignore the warning from the bug, rather than assert the bug is still there

After this change, numpy/numpy#9412 _could_ be backported to fix the bug
  • Loading branch information
eric-wieser authored and 3553x committed Jul 16, 2017
1 parent 684d141 commit 14699c3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pandas/tests/test_algos.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import numpy as np
import pytest
import warnings

from numpy.random import RandomState
from numpy import nan
Expand Down Expand Up @@ -127,7 +128,7 @@ def test_unsortable(self):
arr = np.array([1, 2, datetime.now(), 0, 3], dtype=object)
if compat.PY2 and not pd._np_version_under1p10:
# RuntimeWarning: tp_compare didn't return -1 or -2 for exception
with tm.assert_produces_warning(RuntimeWarning):
with warnings.catch_warnings():
pytest.raises(TypeError, algos.safe_sort, arr)
else:
pytest.raises(TypeError, algos.safe_sort, arr)
Expand Down

0 comments on commit 14699c3

Please sign in to comment.