Build js file at package time & cleanu sdist #9
+71
−48,114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yuvipanda
commented
Nov 14, 2023
yuvipanda
commented
- Stop including the built JS file in the package, instead it is built during sdist time (and hence included in the wheel). Stolen / inspired from JupyterHub itself.
- setuptool_scm includes all checked-in files by default in the sdist (using setuptools_scm forces all SCM files to be packaged into sdist pypa/setuptools-scm#190). This cleans it out to trim down the size of our sdist
- I think our previous wheel files didn't actually have the python package correctly. It is set up correctly now.
- Generated js files are put under a dist/, so we can have non-generated static files under static/ in the future. dist/ is added to .gitignore
- Stop including the built JS file in the package, instead it is built during sdist time (and hence included in the wheel). Stolen / inspired from JupyterHub itself. - setuptool_scm includes *all* checked-in files by default in the sdist (pypa/setuptools-scm#190). This cleans it out to trim down the size of our sdist - I think our previous wheel files didn't actually have the python package correctly. It is set up correctly now. - Generated js files are put under a dist/, so we can have non-generated static files under static/ in the future. dist/ is added to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.