-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize RTD config #999
Modernize RTD config #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Co-authored-by: Georgiana Elena <[email protected]>
The latest failure seems relevant... but at the same time, it seems the file is readable (cat cmd worked) so maybe this is just a hiccup from the RTD run? |
Argh, I tried a few things but they didn't work, so reverted back to @consideRatio's original version. I kinda feel like we are triggering a bug in
I think that they want to be doing |
@choldgraf yeah, I'd say that "python" should be a "conda" instead for the command to make sense. |
for more information, see https://pre-commit.ci
Co-authored-by: Erik Sundell <[email protected]>
@damianavila that Sphinx error is my fault, because we should be making releases of that theme instead of pinning to master ;-) I'll fix tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the bug in our theme, and re-built with RTD. The build is now passing! Here's a link: https://readthedocs.org/projects/2i2c-pilot-hubs/builds/16221520/
The reason our CI/CD says it's failing is because somehow a duplicated build was triggered in RTD, but it should work fine now.
No description provided.