Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize RTD config #999

Merged
merged 10 commits into from
Feb 28, 2022
Merged

Conversation

consideRatio
Copy link
Contributor

No description provided.

.readthedocs.yaml Outdated Show resolved Hide resolved
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@damianavila
Copy link
Contributor

The latest failure seems relevant... but at the same time, it seems the file is readable (cat cmd worked) so maybe this is just a hiccup from the RTD run?

.readthedocs.yaml Outdated Show resolved Hide resolved
@choldgraf
Copy link
Member

choldgraf commented Feb 24, 2022

Argh, I tried a few things but they didn't work, so reverted back to @consideRatio's original version.

I kinda feel like we are triggering a bug in readthedocs. The command that is failing is:

python env create --quiet --name 999 --file docs/environment.yml

I think that they want to be doing conda env create instead...I have no idea why python is being used. Does that seem correct to others?

@sgibson91
Copy link
Member

@choldgraf yeah, I'd say that "python" should be a "conda" instead for the command to make sense.

@choldgraf
Copy link
Member

ah, found it: https://stackoverflow.com/questions/69774313/why-does-rtd-run-python-env-create-instead-of-conda-env-create-when-building

.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
@choldgraf
Copy link
Member

@damianavila that Sphinx error is my fault, because we should be making releases of that theme instead of pinning to master ;-) I'll fix tomorrow

.readthedocs.yaml Outdated Show resolved Hide resolved
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the bug in our theme, and re-built with RTD. The build is now passing! Here's a link: https://readthedocs.org/projects/2i2c-pilot-hubs/builds/16221520/

The reason our CI/CD says it's failing is because somehow a duplicated build was triggered in RTD, but it should work fine now.

@choldgraf choldgraf merged commit cc32b3c into 2i2c-org:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants