Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: setup prettier to autoformat relevant YAML files #807

Merged

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Nov 5, 2021

This resolves #805 by:

  • Adding a .pre-commit-config.yaml file to run prettier specifically
  • Adding a .prettierignore file to ignore
    • Helm templates
    • SOPS encrypted content
    • Markdown and JSON, but not YAML files
  • Running prettier on all YAML files
  • Setting up 2i2c-org on github to use pre-commit.ci for this repo

Review

  • The .pre-commit-config.yaml file
  • The .prettierignore file
  • All autoformatted .yaml files (I saw no issues)

@consideRatio consideRatio force-pushed the pr/prettier-yaml-formatting branch from c8e60f3 to 795b668 Compare November 5, 2021 15:58
@consideRatio consideRatio force-pushed the pr/prettier-yaml-formatting branch from 795b668 to 984535a Compare November 5, 2021 15:59
@yuvipanda yuvipanda requested a review from sgibson91 November 5, 2021 16:22
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me - I like the idea of standardizing what we can, especially things as finnicky as YAML

@consideRatio consideRatio merged commit bf7ce60 into 2i2c-org:master Nov 7, 2021
@consideRatio
Copy link
Contributor Author

With two approvals, and a perception that it's up to me to hit merge, I went for it now that I had some time and ability to context switch to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml_lint action clutters PRs with comments: replace it with pre-commit and a prettier hook
3 participants