Reduce guarantee memory to avoid going beyond the allocatable value #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each node has some allocatable resources [1] If you try to schedule a pod with guarantee requirements above the allocatable values, it will fail to be spawned. With the "very large" option, we are requesting 110G at minimum and that is dangerously close the the theoretical allocatable memory for the n1-standard-32 node. Then, let's give that guarantee value some breath ;-) [1] https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-architecture#memory_cpu
|
I have manually deployed this one to meom staging and it seems to work as intended! |
choldgraf
reviewed
Nov 4, 2021
| @@ -75,7 +75,7 @@ hubs: | |||
| description: "~32 CPU, ~128G RAM" | |||
| kubespawner_override: | |||
| mem_limit: 128G | |||
| mem_guarantee: 110G | |||
| mem_guarantee: 100G | |||
| node_selector: | |||
| node.kubernetes.io/instance-type: n1-standard-32 | |||
| - display_name: "Huge" | |||
There was a problem hiding this comment.
is there something similar we should do for "huge"?
There was a problem hiding this comment.
Fetching info from the nodes:
small >> 5758056Ki >> 5.75 GB allocatable (mem_guarantee: 5GB)
medium >> 27155328Ki >> 27.15 GB allocatable (mem_guarantee: 25GB)
large >> 56183024Ki >> 56.18 GB allocatable (mem_guarantee: 50GB)
very large >> 114336712Ki >> 114.33G allocatable (mem_guarantee: 100GB with this PR)
huge >> 235367296Ki >> 235.37GB allocatable (mem_guarantee: 220G)
I think we are OK with the huge one but happy to discuss all the other values 😉 .
Did you try with |
|
Confirmed that this does work with staging! |
consideRatio
approved these changes
Nov 5, 2021
6 tasks
|
I will merge it as is because this is what I validated on |
|
Follow-up: #809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each node has some allocatable resources [1]
If you try to schedule a pod with guarantee requirements above the
allocatable values, it will fail to be spawned.
With the "very large" option, we are requesting 110G at a minimum and that
is dangerously close to the theoretical allocatable memory for the
n1-standard-32 node. Then, let's give that guarantee value some
breath ;-)
[1] https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-architecture#memory_cpu
More details about the whole debugging lives on the corresponding freshdesk-support thread