Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nfs-server-provisioner subchart in support #613

Merged
merged 17 commits into from
Aug 30, 2021
Merged

Use nfs-server-provisioner subchart in support #613

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
46afd0b
First pass at deploying NFS server in k8s
sgibson91 Aug 12, 2021
a3552ef
Second pass at YAML for NFS in k8s
sgibson91 Aug 12, 2021
aac614c
Third pass at NFS in k8s
sgibson91 Aug 12, 2021
4d89ca3
Delete nfs-server template
sgibson91 Aug 17, 2021
d8b444e
Add nfs-server-provisioner as support chart dependency
sgibson91 Aug 17, 2021
1d718d3
configure nfs-server-provisioner is support chart values.yaml
sgibson91 Aug 17, 2021
090b9b3
Make inclusion of nfs-server-provisioner conditional
sgibson91 Aug 18, 2021
8242a88
Disable using nfs-server-provisioner chart by default
sgibson91 Aug 18, 2021
b714fdc
Use version 4 of NFS client by default
sgibson91 Aug 18, 2021
11a12ab
Merge branch 'automate-nfs' of github.com:sgibson91/pilot-hubs into a…
sgibson91 Aug 18, 2021
7e431e3
Add values reference for nfs-server-provisioner
sgibson91 Aug 19, 2021
7f36b7f
Include default mount options into nfs-provisioner values
sgibson91 Aug 20, 2021
ab9e77d
Allow prometheus, grafana and ingress-nginx to be en/disabled by a fl…
sgibson91 Aug 20, 2021
2445d27
Remove cert-manager reference from support/values.yaml
sgibson91 Aug 23, 2021
b04191f
Revert "Allow prometheus, grafana and ingress-nginx to be en/disabled…
sgibson91 Aug 23, 2021
2e411f6
Change nfs-ganesha's storageclass name
yuvipanda Aug 30, 2021
46805d3
Clarify nfs-external-provisioner options
yuvipanda Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions support/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,9 @@ dependencies:
version: 9.10.3
repository: https://kubernetes.github.io/autoscaler
condition: cluster-autoscaler.enabled

# In-cluster NFS server provisioner
- name: nfs-server-provisioner
version: 1.3.1
repository: https://kvaps.github.io/charts
sgibson91 marked this conversation as resolved.
Show resolved Hide resolved
condition: nfs-server-provisioner.enabled
sgibson91 marked this conversation as resolved.
Show resolved Hide resolved
19 changes: 19 additions & 0 deletions support/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,22 @@ grafana:
access: proxy
isDefault: true
editable: false

sgibson91 marked this conversation as resolved.
Show resolved Hide resolved
nfs-server-provisioner:
enabled: false
storageClass:
# Users will have to opt-in to using NFS-type storage under
# singleuser.storage.dynamic.storageClass
name: nfs
create: true
defaultClass: false
mountOptions:
- vers=4
sgibson91 marked this conversation as resolved.
Show resolved Hide resolved
persistence:
enabled: true
accessMode: ReadWriteOnce
size: 100Gi
# Future option is to reference an xfs storage class. This will allow us to enable quotas.
# https://github.com/pangeo-data/pangeo-cloud-federation/issues/654#issuecomment-861771398
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On most cloud providers, the storageClass is a reference to the underlying physical storage only - spinning disks or SSDs. I think the nfs external provisioner already uses XFS, and so the storageClass wouldn't come up. I think the reference in the provided link is for bare metal instances only.

# https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/gce-pd-csi-driver
storageClass: standard