jupyter-health: enable login via managed groups #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should reduce expired tokens while we wait for refresh tokens to be redeployed
minrk
force-pushed
the
health-manage-groups
branch
from
ff66800 to
c2394f8
Compare
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
so we don't need to specifically name users anymore this will also mean users who have no access won't be able to login, which will probably make more sense
minrk
force-pushed
the
health-manage-groups
branch
from
1c19abc to
84971f7
Compare
for more information, see https://pre-commit.ci
GeorgianaElena
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM! It would be nice to get access like this, without creating any new accounts.
@minrk, please feel free to self merge whenever you are ready to test this.
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/12160246393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #5221
This way, granting access is adding a user to an organization in the provider. We can also grant access to 2i2c members this way.