support chart: disable ingress-nginx admission webhook being troublesome #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/10782358524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingress-nginx chart provides a k8s validation webhook for ingress resources, meaning that it will get contacted whenever an ingress resources is being created/updated.
But, connecting to it can fail, as it does in a new k8s 1.30 cluster it seems. Due to that, I've disabled it systematically to avoid issues.
The drawback is that if we make some esoteric changes, such as modifying a ingress annotation like
nginx.ingress.kubernetes.io/configuration-snippet:, we won't get quick validation if its an seemingly acceptable change. The upside is that we don't get issues with connectivity to the webhook.This was found to be practically needed for #4762.