terraform: add fixme comments about major versions bumps, and reference comments #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has moved us away from open source terraform to BSL licensed terraform, and will have to be reverted |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Nov 7, 2024
Partially reverts 2i2c-org#4745, as Terraform 1.9 is not an open source product.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to ensure we have a modern azure terraform provider version, so this led to some terraform resource inspection for various terraform resouces.
Note we still don't have bumping of terraform resources scheduled in our recurring task calendar. I'll open an issue about it. (EDIT: see #4746 linking to the issue)