terraform, aws: simplify resource tagging by using aws provider's default_tags #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that instead of using
var.tagsand setting that explicitly on all resources, we can usedefault_tagson the aws provider thingy inmain.tfinstead. This also enabled referencingvar.tagsand replacing patterns like{var_cluster_name}, which made it easy to declare a default value involving a cluster name.This turned out perfect and is a robust solution to #4711 with regards to non-hub-specific tags at least.
Only one resource (a budget plan) wasn't already tagged explicitly and could be tagged thanks to
default_tags.