Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak daskhub config defaults #470

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Tweak daskhub config defaults #470

merged 2 commits into from
Jun 14, 2021

Conversation

yuvipanda
Copy link
Member

  • Currently, users have to set these manually, so limiting it
    to 32 prevents provisioning instances larger than that.
  • Set daskhub default to /lab - orgs using dask mostly want to
    use lab as the default

Ref #291 (comment)

yuvipanda added 2 commits June 14, 2021 23:50
@yuvipanda
Remove max limits on dask worker RAM / CPU
d1bc4f8 
Currently, users have to set these manually, so limiting it
to 32 prevents provisioning instances larger than that.

Ref 2i2c-org#291 (comment)
@yuvipanda
Set JupyterLab as default for daskhub
f181cf8
damianavila
damianavila approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think /lab is a sensible default for daskhub.
LGTM.

@yuvipanda yuvipanda mentioned this pull request Jun 14, 2021
Merged
@damianavila damianavila merged commit f181cf8 into 2i2c-org:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianavila damianavila damianavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @damianavila