Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create k8s resources in support chart to run gcp-filestores-backup #4436

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Create k8s resources in support chart to run gcp-filestores-backup #4436

merged 8 commits into from
Jul 17, 2024

Conversation

sgibson91
Copy link
Member

@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
yuvipanda
yuvipanda reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fundamentals of this look fine to me! I think now it's tweaking this until it runs ok in the container continuously.

@sgibson91
Copy link
Member Author

I think now it's tweaking this until it runs ok in the container continuously.

I don't think it will run until gcloud has the necessary credentials - so I will have to complete #4396

@sgibson91 sgibson91 added the deployer:skip-deploy Skips deployment of anything (support, staging, prod) label Jul 17, 2024
@sgibson91 sgibson91 marked this pull request as ready for review July 17, 2024 13:13
@sgibson91 sgibson91 merged commit 2061d4c into 2i2c-org:main Jul 17, 2024
37 checks passed
@sgibson91 sgibson91 deleted the gcp-filestore-backups/k8s-deployment branch July 17, 2024 13:13
@github-actions GitHub Actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/9974919063

sgibson91 added a commit to sgibson91/gcp-filestore-backups that referenced this pull request Sep 12, 2024
@sgibson91
Create a helm chart for gcpFilestoreBackups
d80d481 
Based on config from 2i2c-org/infrastructure#4436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda left review comments

Assignees

@sgibson91 sgibson91

Labels
deployer:skip-deploy Skips deployment of anything (support, staging, prod)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a deployment and service accounts in the support/ chart for gcp-filestore-backup to run
2 participants
@sgibson91 @yuvipanda