Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basehub: default to nfs.enabled / nfs.pv.enabled to false #3666

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Jan 31, 2024

Closes #3654.

We are still not following the best practice of providing a chart (basehub) that works out of the box with its default config, because at least we still have jupyterhub.singleuser.extraVolumeMounts and jupyterhub.custom.singleuserAdmin.extraVolumeMounts that mounts NFS folders even if nfs.enabled and nfs.pv.enabled aren't true, which would make startup fail.

This PR does not revert #3656 because I think many clusters will have hubs enabling and configuring nfs stuff in a common.values.yaml, while individual hubs may then go back to opting out of it.

Overall, this is something I consider an improvement, but it isn't as clearcut as I initially thought.

@consideRatio consideRatio requested a review from a team as a code owner January 31, 2024 12:39

This comment was marked as outdated.

@consideRatio
Copy link
Contributor Author

This change is a systematic change, so it can quickly get out of sync and needs to be updated/reviewed/merged in quick succession. I'd like to update this PR to be mergabe once the PR is reviewed in outs outdated form, where focus is on the kind of changes, and the retroactive update is focused on making sure the changes are systematic once again.

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @consideRatio. Ping me after when I need to take another look after the rebase.

@consideRatio consideRatio force-pushed the pr/transition-default-nfs branch from e2bdb07 to 605e9f6 Compare March 24, 2024 08:56
Comment on lines 66 to +74
nfs:
enabled: true
enabled: false
dirsizeReporter:
enabled: true
shareCreator:
enabled: true
tolerations: []
pv:
enabled: true
enabled: false
Copy link
Contributor Author

@consideRatio consideRatio Mar 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this switches these from true to false, I'm updating all cluster config explicitly configuring nfs to enable nfs stuff.

@consideRatio
Copy link
Contributor Author

Thank you @GeorgianaElena!

I've now rebased and verified the change is sound twice by searching for nfs: across the repo and ensured that configuring nfs: in any way goes hand in hand with configuring nfs.enabled=true and nfs.pv.enabled=true. If we would miss enabling nfs somewhere it were configured, it would be a breaking change.

@consideRatio
Copy link
Contributor Author

Actially I think any mistakes here will be caught by the health check tests, because a user server will be started with storage mounted - storage that can't be mounted unless nfs stuff has been enabled.

I'll go for a merge before new hub PRs are being created as they will be soon.

@consideRatio consideRatio merged commit f2dbd3f into 2i2c-org:master Mar 26, 2024
33 checks passed
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8432986231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

basehub: switch default value of nfs.pv.enabled to false (without changing any final values)
2 participants