-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leap: maintenance notice (basehub: fix override of template_vars) #2318
leap: maintenance notice (basehub: fix override of template_vars) #2318
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a question around your basehub change to the template_paths, which isn't mentioned in your pull request description. See the inline comment.
4e5cd36
to
8a07456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4368269186 |
I wanted to provide a maintenance notice for LEAP as planned with @jbusecke for work in #2209.
As part of this, I also needed to fix a forceful override of
c.JupyterHub.template_vars
so that it didn't make changes totemplate_vars
elsewhere be overridden. Due to that, we will redeploy across all hubs.Related
announcement
template variable influencing default templates #1501