Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEAP Work around for slug handling and user options in kubespawner #2238

Merged
merged 3 commits into from
Feb 22, 2023
Merged

LEAP Work around for slug handling and user options in kubespawner #2238

merged 3 commits into from
Feb 22, 2023

Conversation

pnasrat
Copy link
Contributor

@pnasrat pnasrat commented Feb 21, 2023

See #2237

@pnasrat pnasrat requested a review from damianavila February 21, 2023 18:30
@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp m2lines No Yes Following helm chart values files were modified: common.values.yaml
gcp leap No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp m2lines prod Following helm chart values files were modified: common.values.yaml
gcp leap prod Following helm chart values files were modified: common.values.yaml

consideRatio
consideRatio suggested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add slug: gpu to the profile_list element for Large + GPU to workaround the bug jupyterhub/kubespawner#702 for now to avoid making a user facing change.

@pnasrat
Copy link
Contributor Author

pnasrat commented Feb 22, 2023

Please take another look

consideRatio
consideRatio approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

@pnasrat pnasrat merged commit 6b42705 into master Feb 22, 2023
@pnasrat pnasrat deleted the leap-large-profile-name branch February 22, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@damianavila damianavila Awaiting requested review from damianavila

Assignees

@pnasrat pnasrat

Labels
None yet
Projects
No open projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnasrat @consideRatio