openscapes: update EKS cluster config templates from k8s 1.21 to 1.24 #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
commented
Feb 5, 2023
Comment on lines
+12
to
+26
| /* | ||
| This file is a jsonnet template of a eksctl's cluster configuration file, | ||
| that is used with the eksctl CLI to both update and initialize an AWS EKS | ||
| based cluster. | ||
|
|
||
| This file has in turn been generated from eksctl/template.jsonnet which is | ||
| relevant to compare with for changes over time. | ||
|
|
||
| To use jsonnet to generate an eksctl configuration file from this, do: | ||
|
|
||
| jsonnet << cluster_name >>.jsonnet > eksctl-config.yaml | ||
|
|
||
| References: | ||
| - https://eksctl.io/usage/schema/ | ||
| */ |
There was a problem hiding this comment.
This is a jsonnet comment to be retained after being generated from the jinja2 template, while the {# parts above are jinja2 comments just for this template.jsonnet file.
consideRatio
force-pushed
the
pr/update-openscapes-k8s-version
branch
from
f6ea7dd to
bb15478
Compare
10 tasks
consideRatio
commented
Feb 6, 2023
Comment on lines
-24
to
+44
|
|
||
| // Node definitions for dask worker nodes. Config here is merged | ||
| // with our dask worker node definition, which uses spot instances. | ||
| // A `node.kubernetes.io/instance-type label is set to the name of the | ||
| // *first* item in instanceDistribution.instanceTypes, to match | ||
| // what we do with notebook nodes. Pods can request a particular | ||
| // kind of node with a nodeSelector | ||
| local daskNodes = [ | ||
| // Node definitions for dask worker nodes. Config here is merged | ||
| // with our dask worker node definition, which uses spot instances. | ||
| // A `node.kubernetes.io/instance-type label is set to the name of the | ||
| // *first* item in instanceDistribution.instanceTypes, to match | ||
| // what we do with notebook nodes. Pods can request a particular | ||
| // kind of node with a nodeSelector |
There was a problem hiding this comment.
This is just a relocation of these comments, matching how they now generate from the template.jsonnet file as changed in another unrelated PR.
consideRatio
commented
Feb 6, 2023
| nodeGroups: [n + {clusterName:: $.metadata.name} for n in [ | ||
| ng { | ||
| name: 'core-b', | ||
| name: 'core-a', |
There was a problem hiding this comment.
During this upgrade, I deleted the core-b nodepool and added the core-a nodepool
GeorgianaElena
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Makes sense to me. Thanks @consideRatio
Also, thanks for the inline explanations. Super useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the eksctl configuration template files for the openscapes cluster that I've migrated from k8s 1.21 to k8s 1.24 now.
If you want me to re-formulate something, I'd like to do it in a standalone PR after this and #2149 is merged which also includes the same comments copied to many files.