Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mysql shared db support on AWS #1770

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Cleanup mysql shared db support on AWS #1770

merged 1 commit into from
Oct 13, 2022

Conversation

yuvipanda
Copy link
Member

  • Don't set up mysql provider when db is not enabled
  • Make sure all db related resources are conditional on db being enabled
  • Switch to a maintained fork of the mysql provider

Unblocks #1768

@yuvipanda
Cleanup mysql shared db support on AWS
ab516c0 
- Don't set up mysql provider when db is not enabled
- Make sure all db related resources are conditional on db being
  enabled
- Switch to a maintained fork of the mysql provider

Unblocks 2i2c-org#1768
@yuvipanda yuvipanda requested a review from a team October 13, 2022 16:22
sgibson91
sgibson91 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏻

@yuvipanda yuvipanda merged commit 67f4d56 into 2i2c-org:master Oct 13, 2022
@sgibson91 sgibson91 mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgibson91 sgibson91 sgibson91 approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @sgibson91