Centralize the initContainer that fixes ownership #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support and Staging deployments
Production deployments
|
|
Nice |
consideRatio
reviewed
Aug 4, 2022
consideRatio
approved these changes
Aug 4, 2022
Merged
damianavila
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
This is exactly what I had in mind when I talked about this one at the cycle meeting.
Thanks for investigating it and fixing it, @yuvipanda!!
yuvipanda
force-pushed
the
fix-shared-ownership
branch
from
7c4d380 to
5703326
Compare
|
@yuvipanda, is there anything else you want to add here, otherwise, I think it is ready... |
|
@damianavila ya just wanted to find a time when I've a few hours uninterrupted in case something goes wrong. Hopefully tomorrow. |
We were copy-pasting this, and it was causing shared-readwrite to not be functional in some cases. Fixes 2i2c-org#440
yuvipanda
force-pushed
the
fix-shared-ownership
branch
from
5703326 to
c1fa965
Compare
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/2951686229 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were copy-pasting this, and it was causing shared-readwrite
to not be functional in some cases.
Fixes #440