-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save cilogon administrative client creds #1033
Save cilogon administrative client creds #1033
Conversation
Hey @GeorgianaElena, this PR will create a conflict with #1027 I suggest:
Does that sound OK? |
@sgibson91, of course! |
#1027 is now merged so feel free to update this PR when you have the time :) |
6cc28d9
to
3b3628c
Compare
I've rebased the PR @sgibson91. Also, this new client has recently been approved by CILogon folks 🚀 We just need to figure out how to use it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorgianaElena I pushed a commit to update the hard-coded path in the deployer, otherwise this is great - thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm - this is embedding the CILogon API credentials in our secrets, so that we could re-use them in subsequent iterations in setting up CILogon with our stack. Is that right? That sounds good to me!
Thanks @sgibson91 <3
Yes! Right now they aren't being used since we're still using the old ones for the current setup. Thank you both for the review 🎉 hitting the merge button now |
I've filled in the form in https://cilogon.org/oauth2/admin-register (
2i2c
client name and I used the support email) and it generated this creds. Once the client gets approved we should be able to use them. But until then, let's store them somewhere safe (the old ones will probably become obsolete, but let's keep them both until we figure out the new auth infra ?? )Ref: #967