Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save cilogon administrative client creds #1033

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

GeorgianaElena
Copy link
Member

I've filled in the form in https://cilogon.org/oauth2/admin-register (2i2c client name and I used the support email) and it generated this creds. Once the client gets approved we should be able to use them. But until then, let's store them somewhere safe (the old ones will probably become obsolete, but let's keep them both until we figure out the new auth infra ?? )

Ref: #967

@sgibson91
Copy link
Member

Hey @GeorgianaElena, this PR will create a conflict with #1027

I suggest:

  1. Wait til Secret config refactor and relative path discovery of files in the deployer #1027 is merged
  2. Rename shared/deployer/enc-auth0-credentials.secret.yaml to something sensible: shared/deployer/enc-auth-provider-credentials.secret.yaml?
  3. Add the CILogon credentials to that file

Does that sound OK?

@GeorgianaElena
Copy link
Member Author

@sgibson91, of course!

@sgibson91
Copy link
Member

#1027 is now merged so feel free to update this PR when you have the time :)

@GeorgianaElena
Copy link
Member Author

I've rebased the PR @sgibson91. Also, this new client has recently been approved by CILogon folks 🚀 We just need to figure out how to use it

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgianaElena I pushed a commit to update the hard-coded path in the deployer, otherwise this is great - thank you!!

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm - this is embedding the CILogon API credentials in our secrets, so that we could re-use them in subsequent iterations in setting up CILogon with our stack. Is that right? That sounds good to me!

@GeorgianaElena
Copy link
Member Author

@GeorgianaElena I pushed a commit to update the hard-coded path in the deployer, otherwise this is great - thank you!!

Thanks @sgibson91 <3

Just to confirm - this is embedding the CILogon API credentials in our secrets, so that we could re-use them in subsequent iterations in setting up CILogon with our stack. Is that right? That sounds good to me!

Yes! Right now they aren't being used since we're still using the old ones for the current setup.

Thank you both for the review 🎉 hitting the merge button now

@GeorgianaElena GeorgianaElena merged commit 5500850 into 2i2c-org:master Mar 1, 2022
@GeorgianaElena GeorgianaElena deleted the new-cilogon-creds branch March 1, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants