Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static web content URLs behave differently with trailing slash or not / #1517

Closed
GeorgianaElena opened this issue Jul 13, 2022 · 2 comments · Fixed by #1520
Closed

Static web content URLs behave differently with trailing slash or not / #1517

GeorgianaElena opened this issue Jul 13, 2022 · 2 comments · Fixed by #1520
Assignees
@yuvipanda

Comments

@GeorgianaElena
Copy link
Member

The static web content is available at https://staging.2i2c.cloud/textbook/ but not at https://staging.2i2c.cloud/textbook (note the missing trailing slash)

I would have expected a redirect from https://staging.2i2c.cloud/textbook to https://staging.2i2c.cloud/textbook/ and then see the content.

Maybe something is missing from the nginx config?
@GeorgianaElena GeorgianaElena changed the title Static web content path Static web content path possible issue Jul 13, 2022
@GeorgianaElena GeorgianaElena mentioned this issue Jul 13, 2022
Merged
@choldgraf choldgraf changed the title Static web content path possible issue Static web content URLs behave differently with trailing slash or not / Jul 13, 2022
@damianavila
Copy link
Contributor

damianavila commented Jul 13, 2022 •
edited
Loading

cc @yuvipanda who will surely have inner knowledge about this one 😉.

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Jul 13, 2022
@yuvipanda
Redirect slashless static sites to the slashful version
1def3f7 
slash slash slashes slash slash

Fixes 2i2c-org#1517
@yuvipanda yuvipanda mentioned this issue Jul 13, 2022
Merged
@yuvipanda
Copy link
Member

Fixed in #1520 :)

Repository owner moved this from In progress to Complete in DEPRECATED Engineering and Product Backlog Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
DEPRECATED Engineering and Product Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redirect slashless static sites to the slashful version yuvipanda/pilot-hubs
3 participants
@yuvipanda @damianavila @GeorgianaElena