Merge pull request #705 from sgibson91/add-helm-dep-up

2i2c-org · Sep 24, 2021 · eec4218 · eec4218
2 parents fed2891 + 64ddc34
commit eec4218
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/actions/deploy/action.yml b/.github/actions/deploy/action.yml
@@ -11,12 +11,6 @@ runs:
     - name: Get gcloud info
       run: gcloud info
       shell: bash
-    - name: Fetch helm charts
-      run: |
-        cd hub-templates
-        helm dep up basehub
-        helm dep up daskhub
-      shell: bash
     - name: Setup gcloud auth for docker
       # FIXME: Add more auth providers & registries here as needed
       run: |

diff --git a/deployer/hub.py b/deployer/hub.py
@@ -420,6 +420,12 @@ def deploy(self, auth_provider, secret_key, skip_hub_health_test=False):
         """
         Deploy this hub
         """
+        # Ensure helm charts are up to date
+        os.chdir("hub-templates")
+        subprocess.check_call(["helm", "dep", "up", "basehub"])
+        if self.spec["template"] == "daskhub":
+            subprocess.check_call(["helm", "dep", "up", "daskhub"])
+        os.chdir("..")
 
         generated_values = self.get_generated_config(auth_provider, secret_key)