Skip to content

Commit

Permalink
Set prometheus server's deployment strategy to recreate
Browse files Browse the repository at this point in the history
During deployment of #720,
sometimes CI would fail because the prometheus pod would be
stuck in 'ContainerCreating', as the old pod was holding on to
the persistent disk the new pod needs to start. This was temporarily
fixed by deleting the prometheus pod, but this tells kubernetes
to delete the old pod properly first before starting the new one.

Ref #720 (comment)
  • Loading branch information
yuvipanda committed Oct 5, 2021
1 parent bf9185f commit 964ed9e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions support/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ prometheus:
pushgateway:
enabled: false
server:
deploymentStrategy:
# We have a persistent disk attached, so the default (RollingUpdate)
# can sometimes get 'stuck' and require pods to be manually deleted.
type: Recreate
resources:
# Without this, prometheus can easily starve users
requests:
Expand Down

0 comments on commit 964ed9e

Please sign in to comment.