Error while expanding buffer in dechunker

Serious issue that could cause corrupt data in records. Fixes neo4j#183
2hdddg · Jan 26, 2021 · 81176c5 · 81176c5
1 parent e2f6706
commit 81176c5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/neo4j/internal/bolt/dechunker.go b/neo4j/internal/bolt/dechunker.go
@@ -44,7 +44,9 @@ func dechunkMessage(rd io.Reader, msgBuf []byte) ([]byte, error) {
 
 		// Need to expand buffer
 		if (off + chunkSize) > cap(msgBuf) {
-			msgBuf = append(msgBuf, make([]byte, off+chunkSize)...)
+			newMsgBuf := make([]byte, (off+chunkSize)+4096)
+			copy(newMsgBuf, msgBuf)
+			msgBuf = newMsgBuf
 		}
 		// Read the chunk into buffer
 		_, err = io.ReadFull(rd, msgBuf[off:(off+chunkSize)])