Add terribly insecure cmd: executor for ISETool etc

[sleekweasel]

My first C#!

I know this is horribly insecure, but we're using it for retrieving logs from the phone when the tests are running on a different host: ssh can't access the desktop processes.

def retrieve_phone_log
    tmp = 'wphonetemp'
    driver.execute_script("cmd:cmd /c \"rd /s/q #{tmp} & md #{tmp}\"")
    isetool = 'c:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\Tools\IsolatedStorageExplorerTool\ISETool.exe'
    $devices ||= driver.execute_script("cmd:\"#{isetool}\" enumeratedevices").split("\n")
    $devindex ||= $devices.grep(/#{driver.capabilities['deviceName']}$/).first.split.first
    log = driver.execute_script("cmd:\"#{isetool}\" ts deviceindex:#{$devindex} #{ENV['WINPHONE_APP_ID']} #{tmp}")
    log + driver.execute_script("cmd:cmd /c \"tree /f /a #{tmp} & type #{tmp}\\IsolatedStore\\BadooDebugLog.txt & echo DONE.\"")
end

[NickAb]

@sleekweasel Thanks, looks nice. But I think we might have a simpler solution for your problem.

As I understand you need to retrieve log files from app that is running/installed on device.
We have some code implemented to upload files into local app storage on device in Winium.StoreApps. It uses API that also includes methods for downloading files from devices.

So I can back port it into winphonedriver and you would be able to download file. From this point there are two options:

1. command will download file to any path on the system where the driver is running and then you would be able to read file content using some remote connection.
2. command will download file and then read its content and return it as a string, so that you could get your logs right into test script.

To do this I just need to better understand what isolated storage do you need to access to. There are, I believe, three types or folders: "Local", "Roaming" and "Temp". Do you need to get files from "Local" only or from other folders too?

What do you think about this approach and which option would you prefer?

[sleekweasel]

I need the data on the host running the tests, so that would be option 2, please. And yes, I think I only need local storage.

I'm also wanting to capture the Outerdriver's logfile for the duration of each given test: for analysing inefficiencies in tests' queries, and the ability to kill the emulator when convenient. I had planned to structure that around this 'cmd:' trick, but looks like I'll need something more elegant. :)

[NickAb]

i think the logging part might be done by implementing /session/:sessionId/log. But we will have to rewire logging to sessions and add special logger handler.

[NickAb]

Looking at webdriver and appium commands it seems that appium's driver.pull_file fits the task of downloading files from app storage better than what I proposed before (custom execute command).

[NickAb]

@sleekweasel check #64

This PR adds implementation for PushFile and PullFile commands from Appium's mobile json wire protocol. See usage in PR description.

[sleekweasel]

Thanks for doing this, and sorry it's taken me ages to get back - log file retrieval is kind-of a luxury item compared to just getting tests written at the moment! I will obviously use this once we bump our version. :)

[NickAb]

@sleekweasel no problem, does it wok for your case? I asking because the logs are sometimes/usually stored in Temp storage, not the Local storage. If so, I will need to make some minor updates to #64

[NickAb]

@sleekweasel any updates on logs retrieval?

[sleekweasel]

Hi. Not yet, sorry - we haven't bumped our version and I'm buried in iOS stuff at the moment. :/