Refactor element model #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 22, 2015 09:43
…d of FrameworkElements
|
|
||
| #endregion | ||
|
|
||
| internal class ElementsRegistry |
There was a problem hiding this comment.
А я назвал ElementStorage. Предлагаю выбрать одно название и сделать одинаково
There was a problem hiding this comment.
Да, одно название будет разумно. Но тут сложным момент. Storage все же подразумевает хранение чего-то, а тут скорее мэппинг элументов, которые есть в дереве интерфейса на ключи. Особенно это важно, учтивая то, что в результате сохраняются слабые ссылки на элементы интерфейса. Т.е. элемент интерфейса может быть спокойно удален, если он больше не нужен основной программе. А вот "хранилище" подразумевает сильные ссылки и все вытекающее.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves scattered element logic to single WiniumElement class. Refactor find ocmmands to use virtual root, fix alert command, minor changes.
Fixes #49
Fixes #40