-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull changes from NetlifeBackupSolutions/Winium.StoreApps fork #167
Open
NickAb
wants to merge
29
commits into
master
Choose a base branch
from
pull
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme now has a link to the gist, this makes editing the Capture-specific options a while lot easier
-IsHitTestVisible is intended to prevent the FrameworkElement from consuming the click/tap so that it goes straight to the componenet under. -It's true by default, it has to be set to false epxlicitly. -Thus it doesn't say anything about whether the FrameworkElement is visible or not, just whehter it is clickable
-Dependencies are installed before the app itself -This is required by some app, for instance thoose who uses C++ runtimes -Used by setting a list in Capabilities, this can be done just like setting other options in Capabilities -Added an InstallDependency() function which is a slightly modified version of Install() -Loads the manifestinfo from the path ( using function in Utils) -Installs the package normally
-AppBarButtons have' Label' as their text, not 'Text or 'Content'
-AppBarButtons often lay in a Grid with opacity 0, even when visible. -This grid is outside of the Page in the view hierarchy so 0 must be a default / valid value for the AppBar -Added a function that returns true if : -The FrameworkElement is an AppBarButton -The AppBarButton is visible -The AppBarButtons parents is also available and visible
-If the element is AppBarButton, the function will return the value of CommandBarCheck(...) directely -CommandBarCheck now checks the visibility of all parents -Added check for CommandBar ( in addition to the already existing AppBarButton )
-Changed loop -Renamed functions
Olevegard/appbar
-ClickCommand is forwarded to InnerDriver -InnerDriver performs click by automation peer
-Added id to error when not being able to click button
Changed click in Winium.StoreApps
Currently retrieves result from no-argument extension functions. Should be changed to use DependencyProperties directly, like the implementation in FrameworkElementExtensions does.
…extension Allow attributes from FrameworkElementExtensions.
* changed Windows Phone dependent .csproj files to not use pdbonly debug for any Release config Fixes: CAPSOL-106
* deciding on using “pdbonly” as DebugType for .csproj files * See updated information on `pdbonly` for [CaptureXamarin/pull/337](https://github.com/NetlifeBackupSolutions/Capt ureXamarin/pull/337) Relates to: CAPSOL-106
…x-release-ARM-csproj Fix project files for Release ARM build to store
…SOL-106/fix-release-ARM-csproj Revert "Fix project files for Release ARM build to store"
-Moved functionality to new class, ExtensionPropertyAccessor -Use this new class like the other similar functions
Use version 1.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.