-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import WindowsPhoneDriver as Winium.Silverlight #164
Changes from 10 commits
5b2957e
d2cacb6
ff41881
89035d8
fcbdf1a
737198e
a4d5f81
df97b89
d042560
df2ff2a
2be1a03
01ed6a7
1a5fc91
f291a79
3f9e1c7
b92c814
e65d3de
f133ca5
629ffd0
c37bac3
fe02f4f
0e30af2
7e1197d
95b7c81
1a6c5f9
8e20bbb
838a8d9
fc500ab
09adafe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
REM Run Winium.StoreApps.Driver.exe | ||
start ..\..\Winium.StoreApps.Driver\bin\x86\Release\Winium.StoreApps.Driver.exe | ||
REM Run Winium.Mobile.Driver.exe | ||
start ..\..\Winium.Mobile.Driver\bin\x86\Release\Winium.Mobile.Driver.exe | ||
|
||
REM Run tests | ||
pip install -r requirements.txt | ||
py.test tests --tb=native -s --junitxml=junit-result.xml | ||
|
||
taskkill /im Winium.StoreApps.Driver.exe /f | ||
taskkill /im Winium.Mobile.Driver.exe /f | ||
taskkill /im XDE.exe /f |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
public class CommandInfo | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common.CommandSettings | ||
namespace Winium.Mobile.Common.CommandSettings | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common.CommandSettings | ||
namespace Winium.Mobile.Common.CommandSettings | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common.Exceptions | ||
namespace Winium.Mobile.Common.Exceptions | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
namespace Winium.Mobile.Common | ||
{ | ||
public static class ExtendedDriverCommand | ||
{ | ||
#region Static Fields | ||
|
||
public static readonly string InvokeAppBarItemCommand = "invokeAppBarItem"; | ||
#endregion | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
#region using | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
// <auto-generated /> | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
#region | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
namespace Winium.StoreApps.Common | ||
namespace Winium.Mobile.Common | ||
{ | ||
public enum ResponseStatus | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,19 +2,19 @@ | |
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
<PropertyGroup> | ||
<MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion> | ||
<MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why visual studio version has been downgraded? What version of VS did you use to make changes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have no idea why VS has decided to downgrade it. It happened when I added target for WP Silverlight 8.1 |
||
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
<ProjectGuid>{3C8D0B9C-576B-4778-97B1-6839AA944AEE}</ProjectGuid> | ||
<OutputType>Library</OutputType> | ||
<AppDesignerFolder>Properties</AppDesignerFolder> | ||
<RootNamespace>Winium.StoreApps.Common</RootNamespace> | ||
<AssemblyName>Winium.StoreApps.Common</AssemblyName> | ||
<RootNamespace>Winium.Mobile.Common</RootNamespace> | ||
<AssemblyName>Winium.Mobile.Common</AssemblyName> | ||
<DefaultLanguage>en-US</DefaultLanguage> | ||
<FileAlignment>512</FileAlignment> | ||
<ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
<TargetFrameworkProfile>Profile151</TargetFrameworkProfile> | ||
<TargetFrameworkVersion>v4.6</TargetFrameworkVersion> | ||
<TargetFrameworkProfile>Profile259</TargetFrameworkProfile> | ||
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it because of Silverlight support? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please try to add target for Silverlight by yourself (you need to replace 89035d8 commit) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will check this. |
||
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir> | ||
<RestorePackages>true</RestorePackages> | ||
</PropertyGroup> | ||
|
@@ -43,7 +43,8 @@ | |
<Compile Include="ConnectionInformation.cs" /> | ||
<Compile Include="DriverCommand.cs" /> | ||
<Compile Include="Exceptions\AutomationException.cs" /> | ||
<Compile Include="Exceptions\InnerDriverRequestException.cs" /> | ||
<Compile Include="Exceptions\InnerServerRequestException.cs" /> | ||
<Compile Include="ExtendedCommand.cs" /> | ||
<Compile Include="HttpResponseHelper.cs" /> | ||
<Compile Include="CommandSettings\CommandSettings.cs" /> | ||
<Compile Include="JsonErrorCodes.cs" /> | ||
|
@@ -52,8 +53,9 @@ | |
<Compile Include="ResponseStatus.cs" /> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<Reference Include="Newtonsoft.Json"> | ||
<Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
<HintPath>..\packages\Newtonsoft.Json.6.0.8\lib\portable-net40+sl5+wp80+win8+wpa81\Newtonsoft.Json.dll</HintPath> | ||
<Private>True</Private> | ||
</Reference> | ||
</ItemGroup> | ||
<ItemGroup> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<packages> | ||
<package id="Newtonsoft.Json" version="6.0.8" targetFramework="portable45-net45+win8+wp8+wpa81" /> | ||
</packages> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
|
||
using System; | ||
|
||
using Winium.StoreApps.Logging; | ||
using Winium.Mobile.Logging; | ||
|
||
#endregion | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should look into backwards compatibility and support both names for a couple of releases. If new file is not found, then it should fallback to the old one and log warning message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say that this is backwards compatibility issue. Public API wasn't changed. Do we support work for different driver/server versions?
Will have a look at this case later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look at this myself. It would be nice to have a gradual transition if it easy to implement. Else we should include some useful message if not connection file was found, so it would be easy to pinpoint the problem of incompatible driver and inner server by end user, who might have messed with versions of inner and outer parts.