Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error pages #79

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Add error pages #79

merged 7 commits into from
Nov 4, 2024

Conversation

hkamran80
Copy link
Member

No description provided.

@hkamran80 hkamran80 added the Code enhancement Enchancements to the website code label Nov 2, 2024
Carlgo11
Carlgo11 reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

503.html can be removed. Do you want to keep the <head>-attributes or use <!-- head -->?

@hkamran80
Copy link
Member Author

503.html can be removed. Do you want to keep the <head>-attributes or use <!-- head -->?

Let's keep the <head> element in this file because it does not need all the extra metadata.

@hkamran80 hkamran80 requested review from Carlgo11 November 4, 2024 05:49
@Carlgo11 Carlgo11 merged commit 228c5ad into 2factorauth:master Nov 4, 2024
@Carlgo11 Carlgo11 removed their request for review November 4, 2024 23:35
@hkamran80 hkamran80 deleted the add-error-pages branch November 5, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlgo11 Carlgo11 Carlgo11 approved these changes

Assignees
No one assigned
Labels
Code enhancement Enchancements to the website code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkamran80 @Carlgo11