Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a little more padding between animation and title in detail screen #13

Closed
filiph opened this issue Nov 3, 2018 · 2 comments
Closed

Add a little more padding between animation and title in detail screen #13

filiph opened this issue Nov 3, 2018 · 2 comments
Assignees
@neurowave
Labels
tentative Fix has been applied, waiting for validation before closing

Comments

@filiph
Copy link
Collaborator

filiph commented Nov 3, 2018

Entirely subjective, but I think the "Alan Turing" title needs a little more space above:

screenshot-1541254663661
luigi-rosso added a commit that referenced this issue Nov 3, 2018
@luigi-rosso
Adding padding under vignette. Addresses issue #13.
7eb94ed
@luigi-rosso luigi-rosso added the tentative Fix has been applied, waiting for validation before closing label Nov 3, 2018
@luigi-rosso
Copy link
Contributor

I added our usual 20 pixel padding underneath. @neurowave, feel free to tweak further here:
https://github.com/2d-inc/timeline/blob/7eb94ed948d6567906a1cdd23e8741351882ac30/app/lib/article/article_widget.dart#L189

@filiph
Copy link
Collaborator Author

filiph commented Nov 5, 2018

Hmm, I'm not seeing this change in the UI.

@filiph filiph closed this as completed Nov 27, 2018
@KernelErr KernelErr mentioned this issue Mar 1, 2020
Closed
This was referenced Apr 30, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neurowave neurowave

Labels
tentative Fix has been applied, waiting for validation before closing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luigi-rosso @filiph @neurowave