Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teddy looking direction #82

Closed
barzansaeedpour opened this issue Apr 25, 2019 · 5 comments
Closed

teddy looking direction #82

barzansaeedpour opened this issue Apr 25, 2019 · 5 comments

Comments

@barzansaeedpour
Copy link

teddy's looking direction isn't changing during typing. i'm using flutter 1.2.1 stable and flutter_flare 1.5.0 .
i haven't changed anything.

@luigi-rosso
Copy link
Contributor

Thanks for reporting this @barzansaeedpour, which teddy example are you using? If it's from this repository, which branch is it?

@jaggernod
Copy link

Hey @luigi-rosso, I have also noticed that on a bigger screen (tablet or desktop).

In this screenshot, Teddy is looking to the right despite the caret being on the left:

Screenshot from 2019-05-19 11 44 17

For me, this happens when the Flare World is not the same as the "Flutter Word".
For example, the Flare Agent does not occupy the whole screen.
The thing that I noticed that the _caretGlobal is not properly transformed into _caretWorld. It always stays the same.
This is because the _globalToFlareWorld is always the default one as the setViewTransform is never called.

Noticed that the call to setViewTransform has been removed from Flare's framework sometime after v1.3.

@luigi-rosso
Copy link
Contributor

Good catch, we did accidentally remove setViewTransform! I'm looking into this.

@luigi-rosso
Copy link
Contributor

This should now be fixed on all channels (master, dev, stable).

@luigi-rosso
Copy link
Contributor

Closing this issue, feel free to re-open if you run into further problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants