Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[FEAT] 1차 과제 구현(#1) #2

Merged
merged 1 commit into from
Oct 7, 2021
Merged

✨[FEAT] 1차 과제 구현(#1) #2

merged 1 commit into from
Oct 7, 2021

Conversation

yangsubinn
Copy link
Member

📌 관련 이슈

closed #1

📌 변경 사항 및 이유

1차 과제🍎

UI, 화면 전환, 데이터 전달 구현했습니다

📌 PR Point

📌 참고 사항

@yangsubinn yangsubinn merged commit 2c97415 into main Oct 7, 2021
@yangsubinn yangsubinn deleted the feature/#1 branch October 7, 2021 14:01
Copy link

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수빈님 코드 정말 깔끔하고 보기 좋네요!! 수고하셨습니다🤗🤗🤗

// 초기 다음버튼 비활성화
nextButton.isEnabled = false

// 요소에 따라 정의해둔 함수를 실행

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target처럼 동작에 대한 통일성이 있는 메소드들을 모아서 함수로 뺀 다음 viewDidLoad에서 호출해줘도 좋을 것 같아요!! 👍🏻👍🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와아 좋아여! 다음부터는 그런식으로 해야겠네여👍

// 받아온 이름 넣는 함수
func setNameLabel() {
if let name = message {
nameLabel.text = "\(name)님"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text의 값을 nameLabel.text = "\(name)님 \n환영합니다!" 와 같이 넣어준다면 Label을 2개 만들 필요 없이 하나로 처리가 가능합니다! Storyboard에서 레이아웃을 한번만 잡아도 되고, 라벨을 하나만 사용할 수 있어서 편리해요 ~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 와 그게 더 편하겠네여.. 나중에 같이 수정해서 올려야겠어여🍎

Copy link

@noah0316 noah0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎ코드보고 많이 배워갑니다 너무 고생많으셨어요!! 😃

nameTextField.addTarget(self, action: #selector(textFieldDidChange(textField:)), for: UIControl.Event.editingChanged)
emailTextField.addTarget(self, action: #selector(textFieldDidChange(textField:)), for: UIControl.Event.editingChanged)
pwTextField.addTarget(self, action: #selector(textFieldDidChange(textField:)), for: UIControl.Event.editingChanged)
showPwButton.addTarget(self, action: #selector(showPwButtonClicked(button:)), for: .touchUpInside)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이친구도 addTarget으로 연결해주셨군요!! 이 생각은 못해봤네요👍

Copy link
Member

@heerucan heerucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캐치미 아요 수빈 손배 멋지다 고생 많았당😊


@IBAction func touchUpToSuccess(_ sender: Any) {
guard let nextVC = self.storyboard?.instantiateViewController(withIdentifier: "SuccessViewController") as? SuccessViewController else {return}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

손배야 나 빈칸잽이로서 아까부터 요빈캔손배 좀 보이시네..큼..👻👻

Comment on lines +53 to +58
if pwTextField.isSecureTextEntry == true {
pwTextField.isSecureTextEntry = false
showPwButton.tintColor = .systemBlue
} else {
pwTextField.isSecureTextEntry = true
showPwButton.tintColor = .lightGray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pwTextField.isSecureTextEntry = pwTextField.isSecureTextEntry == true ? false : true
showPwButton.tintColor = pwTextField.isSecureTextEntry == true ? .systemBlue : .lightGray

듀나걸 따라서 삼항연산자 손배를 우리 같이 써보쟈.. 수빈손배 사랑해❤️

Comment on lines +47 to +51
if self.nameTextField.hasText && self.emailTextField.hasText && self.pwTextField.hasText {
nextButton.isEnabled = true
} else {
nextButton.isEnabled = false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 손배야도 삼항연산자로 쇽샥 해주면 우리는 바오밥오나무 탈출이야 수빈손배 우리 탈출해보자 🤟

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아썰 나도 바오밥오나무 탈출한다🌳

func setNameLabel() {
if let name = message {
nameLabel.text = "\(name)님"
nameLabel.sizeToFit()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

손배 왜 나는 sizeToFit()을 몰랐지? 왜 나는 모르고 있었찌?
손배 제법 멋지다.. 🤟👻

Comment on lines +30 to +32
@IBAction func touchUpToGoBack(_ sender: Any) {
self.dismiss(animated: true, completion: nil)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

손배 나는 이거 안해서 매번 빌드했는데 큼.. 손배 제법 콩(콩이 엄마,,❓)순.. 말고 똑순girl이네..😊
캐치미 때와 다르게 좀 얌전하게 코드리뷰 하고 간다릥..🐛🐛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 꽤나 굉장히 얌전하네 손배야... 코리 땡큐쏘마취😗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] iOS 1차 과제
4 participants