[FEAT] iOS 3차 과제 #13
Merged
[FEAT] iOS 3차 과제 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningpop
requested review from
eunseo5355,
Taehyeon-Kim,
yangwon9616,
hyesuuou and
EunHee-Jeong
Taehyeon-Kim
approved these changes
Nov 1, 2021
Comment on lines
15
to
16
| var homeVideoList: [HomeVideo] = [] | ||
| var homeShortsVideoList: [HomeShortsVideo] = [] |
There was a problem hiding this comment.
해당 클래스에서만 사용되는 변수라면 private접근제어자를 이용해서 감싸주는 것도 좋아보입니다! 얘네 같은 경우는 어쨌든 데이터이기 때문에 실수로 외부에서 접근해서 변경되면 안 될 것 같아서요! 참고만 해주세요~
There was a problem hiding this comment.
아.. private!!! OOP강연을 해놓고 이걸 놓치다니ㅋㅋㅋ큐ㅠㅠ 감사합니다~
Comment on lines
+97
to
+99
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets { | ||
| return UIEdgeInsets.zero | ||
| } |
There was a problem hiding this comment.
그냥 생각이 든 건데 다음과 같이 쓸 수도 있어요!
return .zeroThere was a problem hiding this comment.
오... 단축형... 어떤 문법에 의해서 그렇게 되는지 혹시 참고자료나 키워드가 있을까요?
➕[ADD] 4차 세미나 프로젝트 추가(#14)
EunHee-Jeong
approved these changes
Nov 5, 2021
Comment on lines
23
to
26
| homeVideoTableView.dataSource = self | ||
| homeVideoTableView.delegate = self | ||
| homeShortsCollectionView.dataSource = self | ||
| homeShortsCollectionView.delegate = self |
There was a problem hiding this comment.
이 부분은 메서드로 모아서 호출하는게 더 좋다고 하네요 ㅎㅎ
There was a problem hiding this comment.
넴 set~ 으로 묶어서 하는 것을 추천하시는 분들이 많더라고용
There was a problem hiding this comment.
마음이 급해서 저리 하였네유... 다음에는 좀 더 깨끗한 코드로 돌아오겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#12 [FEAT] iOS 3차 과제
📌 변경 사항 및 이유
📌 PR Point
세미나때는 같은 모델을 가지고 TableView와 CollectionView를 만드느라 괜찮았지만,이번엔 다른 모델을 가지고 활용해야해서 CollectionView의 이미지 불러오는 부분을 완성하지 못했습니다.
성공했오요
📌 참고 사항
다음주는 더 미리미리 해두겠습니다...
📌 작동 화면