[FEAT] iOS 4주차 과제 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All File Checked 📝LGTM✨ No Errors or Warnings Found Good Job!
Generated by 🚫 Danger |
- trailing_whitespace
|
아니 저게 뭐시여요...🤭 |
- UIView+ -> UIView+IBInspectable
- UIViewController+makeAlert : alert생성 extension 추가
- Network, NetworkResult, SignUpRequest : 리팩토링 예정
- Result Type과, URLSession을 이용하여 로그인 관련 코드 리팩토링
- 회원가입, 로그인 URLSession 코드 통합 및 Result Type, URLSession 이용하여 회원가입 관련 코드 리팩토링
Assignment/29th-assignment/29th-assignment/Extensions/UIViewController+makeAlert.swift
Outdated
Show resolved
Hide resolved
Assignment/29th-assignment/29th-assignment/Extensions/UIViewController+makeAlert.swift
Outdated
Show resolved
Hide resolved
Assignment/29th-assignment/29th-assignment/Networks/UserSignService.swift
Outdated
Show resolved
Hide resolved
@YoonAh-dev 허허허허 이 모든 건 금잔디 선배들을 위해... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📌 변경 사항 및 이유
Third-party 라이브러리 기술의 근간이 되는 Foundation framework에서 제공하는 URLSession을 이용해보고 싶어
URLSession을 이용해 http 통신을 구현해보았습니다:)
Alamofire와 같은 라이브러리들은 직접구현한 Result Type을 사용하고 있는 걸로 알고 있습니다.
이와 비슷하게 URLSession과 Swift 5부터 추가된 Result Type을 함께 사용해 http 통신을 구현하였습니다ㅎㅎㅎ