-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major upgrades #88
Closed
+205
−90
Closed
Major upgrades #88
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6818dc1
changed to use only 1 subwoofer supplier, added operatorController, a…
rflood07 aab4da6
operator controller good
rflood07 f6aa252
cleaned up button bindings
rflood07 60ad90a
found values for comp bot equation, changed speaker math a wee
rflood07 65c684b
put stage angle good
2491NoMythic fc675e9
tuned some constants and set climber inversions
rflood07 3a84ebe
tuned initial shot and cleanup
2491NoMythic 2d36bce
tuned some shooting
2491NoMythic daeca88
tuned values, works <3
2491NoMythic 1261dc0
odometry better
2491NoMythic d80f84e
amp shot and score 1 autos work
2491NoMythic 873584e
podium shot updated
2491NoMythic 28a4627
Merge branch 'tuneShootingEquationComp' of https://github.com/2491-No…
2491NoMythic 3a825d5
added groundIntake and safe angle when we are on the other side of th…
2491NoMythic 0c4568f
cleanup
2491NoMythic 7aecdbd
changed ground intake control
2491NoMythic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
podium shot updated
- Loading branch information
commit 873584e4791899509e22d9de044e1f99dd2ed766
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SmartDashboard.getNumber call seems dangerous... Even if there is no longer an "amp angle" field on the SmartDashboard, it would put my mind at ease if we just changed the Field.AMPLIFIER_ANGLE to be the value you liked best.
If your testing earlier discovered that there was a particular angle that worked best, we need to make sure that the Field.AMPLIFIER_ANGLE constant gets updated appropriately, instead of leaving that change in the SmartDashboard widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should change this,but to set ur mind at ease, when the Boolean is initialized on SmartDashboard (whenever robot code starts) it is set to whatever the constant is. So if you never change anything on SmartDashboard, you will just use the constant