-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a performance counter that exports all data at the end and avoids… #93
base: master
Are you sure you want to change the base?
Conversation
e7da97a
to
4825ba5
Compare
4825ba5
to
67ccb84
Compare
@@ -66,5 +71,15 @@ void ViewModelCollection::ExportContextPropertiesToQml( QQmlEngine* engine ) | |||
void ViewModelCollection::SetRootObject( QObject* object ) | |||
{ | |||
m_eventFilter->FilterEventsDirectedAtThisObject( object ); | |||
|
|||
#if !defined( Q_OS_ANDROID ) | |||
if( m_opts->RunningGuiTests() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhoffman219 Unless we end up discovering some way in which the GuiTest(s) are fundamentally in conflict with how the PerformanceCounter works, then I think this is a good spot to place some sample code (since it won't execute other than during tests).
I ran the gui tests and I observed that this code is executing, but I still didn't manage to get to a point where the PerformanceCounter would dump out its statistics in ReportRequest::ExportReport()
Hoping you can help me add code here that would result in some printing of stats, even if the numbers are extremely boring when running the GuiTest of this app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. And if you want to launch the app in GuiTest mode:
build/src/app/app -g
... and then additionally you might want to hack this 1
to make the app stay open longer so you can press buttons and cause more GUI activity before the app auto-closes. This line is where to hack:
… mallocs.