chore: upgrade to Credo 0.5.2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
|
Haven't addressed 2060-io/did-web-anoncreds-method#2, but If you agree I can add a follow up pr that makes sure the issuerId matches |
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
|
Thanks a lot @TimoGlastra! I'm experiencing issues when running the tests under node 20, but we can fix it later along with other updates needed to this repo. |
genaris
approved these changes
May 1, 2024
|
Ah I only tested locally using Node 18... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the package to Credo 0.5.2 (latest stable).
It also does some clean up of unused dependencies, and add a few tests.
I haven't added tests yet for revocation status list as I need to dive a bit deeper into how it exactly works (also opened an issue here: 2060-io/did-web-anoncreds-method#1). I'm thinking of making our implementation static, and thus maybe deviating from the spec a bit, but would also be interested to hear your opinion on an AnonCreds did:web "light" mode using purely static files (so no timestamp querying).