Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인게임 particle 적용 #138

Merged
merged 4 commits into from
Dec 11, 2024
Merged

인게임 particle 적용 #138

merged 4 commits into from
Dec 11, 2024

Conversation

dgg1dbg
Copy link
Contributor

@dgg1dbg dgg1dbg commented Dec 11, 2024

인게임 particle 적용

Related Issue(s)

resolves #85

PR Description

파티클 적용

  • 카메라 선 닿았을 때
  • 쓰레기 맞게 버렸을 때
  • 목적지에 도달했을 때

Changes Included

  • Added new feature(s)
  • Fixed identified bug(s)
  • Updated relevant documentation

Screenshots (if UI changes were made)

Attach screenshots or GIFs of any visual changes. (Only for frontend-related changes)

Notes for Reviewer

Any specific instructions or points to be considered by the reviewer.


Reviewer Checklist

  • Code is written in clean, maintainable, and idiomatic form.
  • Manual testing has been performed to ensure the PR works as expected.
  • Code review comments have been addressed or clarified.

Additional Comments

Add any other comments or information that might be useful for the review process.

@dgg1dbg dgg1dbg added this to the Sprint 4 milestone Dec 11, 2024
@dgg1dbg dgg1dbg requested review from gyusang and vexatone December 11, 2024 11:11
@dgg1dbg dgg1dbg self-assigned this Dec 11, 2024
@snjlee58 snjlee58 self-requested a review December 11, 2024 11:22
Copy link
Contributor

@snjlee58 snjlee58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@gyusang gyusang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly!

@gyusang gyusang merged commit cf533d1 into dev Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

음향 및 파티클 효과 적용
3 participants