feat: 게시물 좋아요, 공유 수 올리는 service, controller 계층 구현 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-backend into feature/initial-setup
…d-backend into feature/initial-setup
…d-backend into feature/initial-setup
yerim123456
requested review from
hye-on,
jooda00,
uijin-j,
medoeun and
toughCircle
📊 Jacoco Test Coverage
|
jooda00
previously approved these changes
Aug 25, 2024
| @@ -28,4 +34,20 @@ public BaseApiResponse<PostSearchRes> getPosts( | |||
| return new BaseApiResponse<>(HttpStatus.OK, StatusCode.OK.getMessage(), res); | |||
| } | |||
|
|
|||
| // 좋아요 수 증가시키는 api | |||
| @ResponseStatus(HttpStatus.OK) | |||
| @PatchMapping("/{postId}/like") | |||
There was a problem hiding this comment.
💭 잘은 모르지만 저희 like로 단수형일까요?
There was a problem hiding this comment.
넵! 저번에 테크스택 작성할 때 그렇게 작성했어서 우선 저렇게 해두었습니다! 혹시 복수형으로 변경하는 게 더 좋을까요?
There was a problem hiding this comment.
엇 아니요! 제가 잘 몰라서 여쭤본거라 편하게 해주셔도 좋을 것 같아요
| @Service | ||
| @Transactional(readOnly = true) | ||
| @RequiredArgsConstructor | ||
| @Slf4j |
There was a problem hiding this comment.
❓ PostService에서는 아직 log를 안 찍으시는 것 같은데 혹시 다른 용도로 넣으신건지 궁금합니다!
There was a problem hiding this comment.
아 지워두겠습니다! log 찍어보고 안 지웠나봐요! 감사합니다:)
📊 Jacoco Test Coverage
|
📊 Jacoco Test Coverage
|
📊 Jacoco Test Coverage
|
jooda00
approved these changes
Aug 25, 2024
hye-on
reviewed
Aug 25, 2024
Comment on lines
28
to
32
| // 외부 API 호출 | ||
| facebookAdapter.increaseLikeCount(postId); | ||
| twitterAdapter.increaseLikeCount(postId); | ||
| instagramAdapter.increaseLikeCount(postId); | ||
| } |
There was a problem hiding this comment.
🚨
각 포스트의 타입의 맞는 api를 호출해야될것 같아요
그리고 스레드가 빠져있습니다!
There was a problem hiding this comment.
말씀해주셔서 감사합니다! 해당 부분 수정했습니다.
ff94cb2
hye-on
reviewed
Aug 25, 2024
src/main/java/team05/integrated_feed_backend/module/post/event/LikeCountIncreaseEvent.java
Outdated
Show resolved
Hide resolved
uijin-j
approved these changes
Aug 25, 2024
…d-backend into feature/post-like&share-increase # Conflicts: # src/main/java/team05/integrated_feed_backend/module/post/entity/Post.java
📊 Jacoco Test Coverage
|
📊 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ 관련 이슈
Resolves #22
👩💻 구현 내용
💬 코멘트
@RestControllerAdviceGlobalExceptionHandler에 추가하였습니다.💭 고려한 점